Open
Conversation
e55e953 to
0a41e59
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1686 +/- ##
==========================================
- Coverage 28.19% 28.03% -0.16%
==========================================
Files 67 67
Lines 6949 6988 +39
==========================================
Hits 1959 1959
- Misses 4848 4887 +39
Partials 142 142 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0a41e59 to
bffe898
Compare
Collaborator
|
@Prashansa-K can you please take a look? |
cca6aaf to
278bde8
Compare
Contributor
|
Also, some tests wherever relevant would be great! |
Contributor
Author
could you share the full command line used? this works for me $ ./deck gateway validate --konnect-addr https://us.api.konghq.tech --konnect-token $KONNECT_TOKEN_DEV test.json
$ cat test.json
{ "_format_version": "3.0"
, "_konnect": {"control_plane_id": "c4fe2fd4-c3e1-494e-b1ea-40a73415c456"}
} |
ea251e2 to
2a2d065
Compare
Introduce the --konnect-control-plane-id flag, which is mutually exclusive with the --konnect-control-plane-name flag. While names are more user-friendly, IDs are better suited for automation scripts due to their simplicity (no spaces, special characters, or sensitive names). This flag is intended for internal use and is therefore hidden.
Remove "warning:" as it is preceded by "Error:"
2a2d065 to
becd8f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce the --konnect-control-plane-id flag, which is mutually exclusive with the --konnect-control-plane-name flag. While names are more user-friendly, IDs are better suited for automation scripts due to their simplicity (no spaces, special characters, or sensitive names). This flag is intended for internal use and is therefore hidden.
requires Kong/go-database-reconciler#303