Improve native Windows editor and config defaults#936
Merged
Kohei-Wada merged 1 commit intoMay 31, 2026
Merged
Conversation
Owner
|
@Martinnn674 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #825.
Summary
$EDITORas the first choice, then use Windows-specific fallbacks:code,notepad,vim%LOCALAPPDATA%\taskdogfor data and%APPDATA%\taskdogfor config on native Windows when XDG variables are not setVerification
uv run --with ruff ruff format --config pyproject.toml ...uv run --with ruff ruff check --fix --config pyproject.toml ...uv run --package taskdog-core --extra dev python -m pytest packages/taskdog-core/tests/shared/test_xdg_utils.py -q(10 passed)uv run --package taskdog-ui --extra dev python -m pytest packages/taskdog-ui/tests/utils/test_editor.py -q(13 passed)uv run --package taskdog-core --extra dev mypy --config-file pyproject.toml packages/taskdog-core/src/taskdog_core/shared/xdg_utils.pyuv run --package taskdog-ui --extra dev mypy --config-file pyproject.toml packages/taskdog-ui/src/taskdog/utils/editor.py