feat(ui): add w/b fast horizontal scroll to the TUI task table#935
Merged
Conversation
The gantt view supports w/b to jump across the timeline quickly, but the table view had no equivalent fast horizontal navigation — only h/l, which scroll one small step at a time. Mirror the gantt's week-jump bindings on the table so navigation is consistent across both views. - Bind w/b to fast right/left horizontal scroll on TaskTable. - Extract the existing h/l step to HORIZONTAL_SCROLL_SIZE and add HORIZONTAL_FAST_SCROLL_SIZE for the w/b step.
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
The implementation correctly adds fast horizontal scrolling (w/b keys) to the TUI task table, mirroring the gantt view behavior. The changes are well-structured with proper constant extraction, correct implementation of the scroll actions, and comprehensive test coverage. No blocking issues found.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The gantt view supports
w/bfor fast horizontal navigation across the timeline, but the table view had no equivalent — onlyh/l, which scroll one small step at a time. This was inconsistent between the two views.This adds
w/bfast horizontal scrolling to the TUI task table, mirroring the gantt's week-jump bindings:w→ fast scroll right,b→ fast scroll left (HORIZONTAL_FAST_SCROLL_SIZE = 40, vs the existingh/lstep of10).h/lstep is extracted toHORIZONTAL_SCROLL_SIZE.The table uses viewport scrolling (not a column cursor like the gantt), so
w/bare a larger fixed scroll step rather than a column jump.Test plan
tests/tui/widgets/test_task_table.pycovering the binding wiring and that the fast step exceeds the normal step.ruff/mypyclean; fulltaskdog-uisuite (908 tests) passing.