test(mcp): cover invalid ISO datetime paths for list_audit_logs#933
Merged
Conversation
Add a parametrized test asserting list_audit_logs raises ValueError when 'since' or 'until' is not a valid ISO datetime. These were the only uncovered branches in task_audit.py (82% -> 100%). Closes #878
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR adds comprehensive test coverage for invalid datetime handling in list_audit_logs, bringing task_audit.py to 100% coverage. The parametrized test follows existing patterns and correctly validates error handling for both since and until parameters. The implementation is sound with no blocking issues identified.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
list_audit_logsraises a customValueErrorwhensinceoruntilis not a valid ISO datetime, but those twoexcept ValueErrorbranches were the only uncovered code intask_audit.py.Added a parametrized test (mirroring the existing
test_optimize_schedule_invalid_datetime/test_fix_actual_times_invalid_datetimepatterns) covering invalidsinceanduntilvalues.Test plan
cd packages/taskdog-mcp PYTHONPATH=src uv run python -m pytest --cov=taskdog_mcp --cov-report=term-missingtask_audit.py: 82% → 100%Closes #878