Skip to content
This repository was archived by the owner on Jul 2, 2026. It is now read-only.

Make sure server URL always ends with '/'#7

Open
bonukai wants to merge 3 commits into
KodeStar:masterfrom
bonukai:revert-2-patch-1
Open

Make sure server URL always ends with '/'#7
bonukai wants to merge 3 commits into
KodeStar:masterfrom
bonukai:revert-2-patch-1

Conversation

@bonukai

@bonukai bonukai commented Oct 5, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@KodeStar

KodeStar commented Oct 5, 2021

Copy link
Copy Markdown
Owner

Might be helpful to add a comment on why this will work better.

@bonukai

bonukai commented Oct 5, 2021

Copy link
Copy Markdown
Contributor Author

@KodeStar
I do not know much about Vue.js, but from what I can see, server URL is set here:
https://github.com/KodeStar/audiosilo/blob/1f1658a6d88103f8eee97e88d182011d801eb940/components/LoginStatus.vue#L50-L52 which in turn will call mutation here: https://github.com/KodeStar/audiosilo/blob/1f1658a6d88103f8eee97e88d182011d801eb940/store/app/mutations.js#L56-L58

If we add '/' there, then we can always assume, that state.server ends with '/' and we can join paths with '+' in those places:
https://github.com/KodeStar/audiosilo/blob/4ea4e04c22c4a5ee2cc8c44b5e820621faf09396/plugins/audio.js#L70
https://github.com/KodeStar/audiosilo/blob/1f1658a6d88103f8eee97e88d182011d801eb940/store/app/getters.js#L6
https://github.com/KodeStar/audiosilo/blob/1f1658a6d88103f8eee97e88d182011d801eb940/store/app/actions.js#L54

My previous pull request did not realy fix it, it's still not possible to use URL without forward slash at the end, app will try to connect to https://audioserve.zderadicka.euauthenticate/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants