Added a new sortOrder option to sort menu items when they are added t…#381
Open
B4rb4ross4 wants to merge 1 commit intoKnpLabs:masterfrom
Open
Added a new sortOrder option to sort menu items when they are added t…#381B4rb4ross4 wants to merge 1 commit intoKnpLabs:masterfrom
B4rb4ross4 wants to merge 1 commit intoKnpLabs:masterfrom
Conversation
Contributor
Author
|
I haven't changed the extra methods. I could fix the type hints in this branch if you like or I could create a separate pr. Just wondering how that could ever be merge to master if the build is failing ;) |
garak
approved these changes
Jun 13, 2023
Chris53897
reviewed
Aug 25, 2023
| $menu->addChild('c2', ['sortOrder' => 4]); | ||
| $menu->addChild('c3', ['sortOrder' => 1]); | ||
| $menu->addChild('c4', ['sortOrder' => 3]); | ||
|
|
Contributor
There was a problem hiding this comment.
Is this line missing here?
$menu->reorderChildren();
garak
requested changes
Oct 9, 2023
Collaborator
garak
left a comment
garak
left a comment
There was a problem hiding this comment.
please address problems highlighted by phpstan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…o the menu.
Suggestion for #380