Skip to content

Fix a bug where observable properties of a row's entity were being cached #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cwohlman wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix a bug where observable properties of a row's entity were being cached #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions build/KoGrid.debug.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* koGrid JavaScript Library
* Authors: https://github.com/ericmbarnard/koGrid/blob/master/README.md
* License: MIT (http://www.opensource.org/licenses/mit-license.php)
* Compiled At: 01/11/2013 15:58:36
* Compiled At: 02/18/2014 12:09:35
***********************************************/

(function (window) {
Expand Down Expand Up @@ -1661,7 +1661,7 @@ window.kg.Row = function (entity, config, selectionService) {
self.afterSelectionChange = config.afterSelectionChangeCallback;
self.propertyCache = {};
self.getProperty = function (path) {
return self.propertyCache[path] || (self.propertyCache[path] = window.kg.utils.evalProperty(self.entity, path));
return window.kg.utils.evalProperty(self.entity, path);
};
};

Expand Down
4 changes: 2 additions & 2 deletions koGrid-2.1.1.debug.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* koGrid JavaScript Library
* Authors: https://github.com/ericmbarnard/koGrid/blob/master/README.md
* License: MIT (http://www.opensource.org/licenses/mit-license.php)
* Compiled At: 01/11/2013 15:58:36
* Compiled At: 02/18/2014 12:09:35
***********************************************/

(function (window) {
Expand Down Expand Up @@ -1661,7 +1661,7 @@ window.kg.Row = function (entity, config, selectionService) {
self.afterSelectionChange = config.afterSelectionChangeCallback;
self.propertyCache = {};
self.getProperty = function (path) {
return self.propertyCache[path] || (self.propertyCache[path] = window.kg.utils.evalProperty(self.entity, path));
return window.kg.utils.evalProperty(self.entity, path);
};
};

Expand Down
2 changes: 1 addition & 1 deletion src/classes/row.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,6 @@ window.kg.Row = function (entity, config, selectionService) {
self.afterSelectionChange = config.afterSelectionChangeCallback;
self.propertyCache = {};
self.getProperty = function (path) {
return self.propertyCache[path] || (self.propertyCache[path] = window.kg.utils.evalProperty(self.entity, path));
return window.kg.utils.evalProperty(self.entity, path);
};
};