feat: add WebXR helper component#9
Conversation
|
Thanks for doing that and I see the issue. So the cubeAxes can be turned on by a property. Maybe you can delay the binding of the camera when that prop get turned on? |
a25cfc9 to
5b6416a
Compare
|
I can't see anything related to this property, so I added a |
|
I think that looks good to me. No need to worry about trame-vtk for now. Thanks for fixing that oversight. |
|
🎉 This PR is included in version 3.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
| @@ -561,7 +561,6 @@ export class ClientView { | |||
| .getActors() | |||
| .forEach(({ setVisibility }) => setVisibility(false)); | |||
|
|
|||
There was a problem hiding this comment.
shouldn't you call setCubeAxesVisibility to avoid code duplication
Context:
I want to make a trame-vtk widget to support WebXR in Trame.
Here's the trame-vtk PR: Kitware/trame-vtk#81
This PR:
This component is a wrapper for vtk.js'
vtkWebXRRenderWindowHelper. It has two methodsstartXRandstopXRand can triggerenterXRandexitXRevents.drawControllersRaycan be set to true to draw rays to represent the controllers.To make the WebXR view work with a VtkView, I had to comment a line in
ClientView(last commit). I don't really understand what it does and I get the same results with and without it. @jourdain : do you know what's the purpose of the "Cube axes" section ? I don't understand why it's there since its visibility is always false and it makes the WebXR helper mess with the transform matrix...