docs(website): replace old website by vitepress#3315
Conversation
c87f049 to
849aa50
Compare
2100255 to
0dfd2ea
Compare
|
@finetjul Could you review this PR? I've added the example build, we can merge it and continue updating it. |
|
Thanks @daker, this is amazing! But can you rename your commit to |
0dfd2ea to
dbe7e10
Compare
|
@jourdain it's done |
| # WebGPU Examples | ||
|
|
||
| WebGPU is the upcoming high performance rendering API coming soon to browsers across all major platforms. vtk.js has preliminary support for WebGPU and you can explore some of its features in the examples below. Note that both WebGPU and our support for it are still under development so these examples may break as the API changes. Most of these examples have been tested with Chrome Canary on Windows and MacOS. | ||
|
|
There was a problem hiding this comment.
Are the WebGPU examples removed in the gallery?
There was a problem hiding this comment.
i don't recall we had WebGPU examples in the gallery https://kitware.github.io/vtk-js/examples/#Applications
There was a problem hiding this comment.
From the diff, it seems that the listing of the examples were removed in that md file.
There was a problem hiding this comment.
There was a problem hiding this comment.
Although those links should have the extra arg to activate webgpu... Weirdly enough, those links don't seems to work either.
There was a problem hiding this comment.
Ah, I see. In theory, they should appear in the gallery
| run: npm run doc:generate-gallery | ||
| - name: Build docs | ||
| run: npm run doc:minified | ||
| run: npm run doc:build |
There was a problem hiding this comment.
Also that step trigger the following error
[vite:vue] [plugin vite:vue] Documentation/content/api/Filters_General_ContourTriangulator.md (163:13): Element is missing end tag.
file: /Users/sebastien.jourdain/Desktop/vtk-js/Documentation/content/api/Filters_General_ContourTriangulator.md:163:13
There was a problem hiding this comment.
Also that step trigger the following error
[vite:vue] [plugin vite:vue] Documentation/content/api/Filters_General_ContourTriangulator.md (163:13): Element is missing end tag. file: /Users/sebastien.jourdain/Desktop/vtk-js/Documentation/content/api/Filters_General_ContourTriangulator.md:163:13
i am not sure this, i will retest again on my machine
|
The build steps don't complete without errors. |
dbe7e10 to
c02ff66
Compare
|
@jourdain i think it should work now, here are the steps: npm run build:release |
|
The PR check failures are due to the command being renamed from doc to docs. |
|
Looks good to me, but we need to ensure that we have time to monitor and fix any major issue once we merge it. |
|
@finetjul can you handle it sometime this week? |
|
@jourdain yes that's the goal, we can merge then i will to fix any remaning issue, the OfflineLocalView example is present in the list
|
|
Here you go @daker ! Hopefully it will be a somewhat smooth transition ;-) |
|
I guess you have a PR coming soon to fix the doc/docs call issue on the ci. |
|
Please tag me so I can review/merge them as fast as I see them ;-) |
|
Wow, it is up and live... |
|
I see some issue with the logo and the examples images but the rest seems in pretty good shape! Well done! |
|
@jourdain yes not bad, i will fix the remaning issues in few hours |
|
It seems that the examples are not available either when you click on them. |
|
I pushed a fix when I always use a base of => still does not fix images and examples. I think more work needs to be done to properly use the |
|
Do we need both |
|
No only docs:build-examples, you can omit the first one |
|
Please update the ci file to skip it. |
|
Yes i will fix the remaining issues tonight |
|
@daker I tried to build the website locally with no luck. I have the following warning:
And it seems to fail with text such as |
|
@finetjul are you sure your local workspace is clean ? i have fixed all those isssues and we don't have {% endnote %} in develop_requirement.md anymore https://raw.githubusercontent.com/Kitware/vtk-js/948a8979005128997919ddb480979f14b55c7fe5/Documentation/docs/develop_requirement.md |
|
Indeed, my bad, my master was outdated. 😅 After updating it, I have the following error: I fix it by calling |


Context
Results
Changes
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting