Skip to content

docs(website): replace old website by vitepress#3315

Merged
jourdain merged 1 commit intoKitware:masterfrom
daker:switch-vitepress
Feb 2, 2026
Merged

docs(website): replace old website by vitepress#3315
jourdain merged 1 commit intoKitware:masterfrom
daker:switch-vitepress

Conversation

@daker
Copy link
Copy Markdown
Collaborator

@daker daker commented Aug 14, 2025

Context

Results

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

@daker
Copy link
Copy Markdown
Collaborator Author

daker commented Aug 14, 2025

@floryst

@daker daker force-pushed the switch-vitepress branch 2 times, most recently from c87f049 to 849aa50 Compare February 1, 2026 01:09
@daker daker marked this pull request as ready for review February 1, 2026 01:09
@daker daker force-pushed the switch-vitepress branch 3 times, most recently from 2100255 to 0dfd2ea Compare February 1, 2026 21:15
@daker
Copy link
Copy Markdown
Collaborator Author

daker commented Feb 1, 2026

@finetjul Could you review this PR? I've added the example build, we can merge it and continue updating it.

@jourdain
Copy link
Copy Markdown
Collaborator

jourdain commented Feb 2, 2026

Thanks @daker, this is amazing! But can you rename your commit to docs(website): replace old website by vitepress so we don't trigger a release for no change in the library.

@daker daker changed the title feat(Documentation): migrate to vitepress docs(website): replace old website by vitepress Feb 2, 2026
@daker
Copy link
Copy Markdown
Collaborator Author

daker commented Feb 2, 2026

@jourdain it's done

# WebGPU Examples

WebGPU is the upcoming high performance rendering API coming soon to browsers across all major platforms. vtk.js has preliminary support for WebGPU and you can explore some of its features in the examples below. Note that both WebGPU and our support for it are still under development so these examples may break as the API changes. Most of these examples have been tested with Chrome Canary on Windows and MacOS.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the WebGPU examples removed in the gallery?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't recall we had WebGPU examples in the gallery https://kitware.github.io/vtk-js/examples/#Applications

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the diff, it seems that the listing of the examples were removed in that md file.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although those links should have the extra arg to activate webgpu... Weirdly enough, those links don't seems to work either.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. In theory, they should appear in the gallery

Comment thread .github/workflows/publish.yml Outdated
run: npm run doc:generate-gallery
- name: Build docs
run: npm run doc:minified
run: npm run doc:build
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: => docs:build ?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also that step trigger the following error

[vite:vue] [plugin vite:vue] Documentation/content/api/Filters_General_ContourTriangulator.md (163:13): Element is missing end tag.
file: /Users/sebastien.jourdain/Desktop/vtk-js/Documentation/content/api/Filters_General_ContourTriangulator.md:163:13

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And much more after too

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes i will fix it

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also that step trigger the following error

[vite:vue] [plugin vite:vue] Documentation/content/api/Filters_General_ContourTriangulator.md (163:13): Element is missing end tag.
file: /Users/sebastien.jourdain/Desktop/vtk-js/Documentation/content/api/Filters_General_ContourTriangulator.md:163:13

i am not sure this, i will retest again on my machine

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@jourdain
Copy link
Copy Markdown
Collaborator

jourdain commented Feb 2, 2026

The build steps don't complete without errors.

npm run build:release
npm run build:examples
npm run doc:generate-api
npm run doc:generate-examples
npm run doc:generate-sidebar
npm run doc:generate-gallery
npm run doc:build # <-- typo + when running (docs:build) it fails
npm run doc:build-examples

@jourdain jourdain self-requested a review February 2, 2026 15:55
Copy link
Copy Markdown
Collaborator

@jourdain jourdain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really amazing work, but we need to make sure the CI will complete (no error) and that API is not failing with "element missing endtag"

Image

@daker
Copy link
Copy Markdown
Collaborator Author

daker commented Feb 2, 2026

@jourdain i think it should work now, here are the steps:

npm run build:release
npm run docs:generate-api # <-- i have added an "s" doc to follow vitepress naming
npm run docs:generate-examples
npm run docs:generate-sidebar
npm run docs:generate-gallery
npm run docs:build
npm run docs:build-examples <- examples for the websites are build with rollup now, much faster compared to webpack

@daker
Copy link
Copy Markdown
Collaborator Author

daker commented Feb 2, 2026

The PR check failures are due to the command being renamed from doc to docs.

@jourdain
Copy link
Copy Markdown
Collaborator

jourdain commented Feb 2, 2026

Looks good to me, but we need to ensure that we have time to monitor and fix any major issue once we merge it.

@jourdain jourdain self-requested a review February 2, 2026 17:16
@jourdain
Copy link
Copy Markdown
Collaborator

jourdain commented Feb 2, 2026

@finetjul can you handle it sometime this week?

@daker
Copy link
Copy Markdown
Collaborator Author

daker commented Feb 2, 2026

@jourdain yes that's the goal, we can merge then i will to fix any remaning issue, the OfflineLocalView example is present in the list

image

@jourdain jourdain merged commit fe574fa into Kitware:master Feb 2, 2026
1 of 2 checks passed
@jourdain
Copy link
Copy Markdown
Collaborator

jourdain commented Feb 2, 2026

Here you go @daker ! Hopefully it will be a somewhat smooth transition ;-)

@jourdain
Copy link
Copy Markdown
Collaborator

jourdain commented Feb 2, 2026

I guess you have a PR coming soon to fix the doc/docs call issue on the ci.

@jourdain
Copy link
Copy Markdown
Collaborator

jourdain commented Feb 2, 2026

Please tag me so I can review/merge them as fast as I see them ;-)

@daker daker deleted the switch-vitepress branch February 2, 2026 17:31
@jourdain
Copy link
Copy Markdown
Collaborator

jourdain commented Feb 2, 2026

Wow, it is up and live...

@jourdain
Copy link
Copy Markdown
Collaborator

jourdain commented Feb 2, 2026

I see some issue with the logo and the examples images but the rest seems in pretty good shape! Well done!

@daker
Copy link
Copy Markdown
Collaborator Author

daker commented Feb 2, 2026

@jourdain yes not bad, i will fix the remaning issues in few hours

@jourdain
Copy link
Copy Markdown
Collaborator

jourdain commented Feb 2, 2026

It seems that the examples are not available either when you click on them.

@jourdain
Copy link
Copy Markdown
Collaborator

jourdain commented Feb 2, 2026

I pushed a fix when I always use a base of /vtk-js. The build is currently running.

=> still does not fix images and examples. I think more work needs to be done to properly use the /vtk-js base.

@jourdain
Copy link
Copy Markdown
Collaborator

jourdain commented Feb 2, 2026

Do we need both build:examples and docs:build-examples?

@daker
Copy link
Copy Markdown
Collaborator Author

daker commented Feb 2, 2026

No only docs:build-examples, you can omit the first one

@jourdain
Copy link
Copy Markdown
Collaborator

jourdain commented Feb 2, 2026

Please update the ci file to skip it.

@daker
Copy link
Copy Markdown
Collaborator Author

daker commented Feb 2, 2026

Yes i will fix the remaining issues tonight

@finetjul
Copy link
Copy Markdown
Member

@daker I tried to build the website locally with no luck.

I have the following warning:

The language './webpack.config.js' is not loaded, falling back to 'txt' for syntax highlighting.

And it seems to fail with text such as {% endnote %} in develop_requirement.md (Markdown is not applied ?)

@daker
Copy link
Copy Markdown
Collaborator Author

daker commented Feb 16, 2026

@finetjul are you sure your local workspace is clean ? i have fixed all those isssues and we don't have {% endnote %} in develop_requirement.md anymore https://raw.githubusercontent.com/Kitware/vtk-js/948a8979005128997919ddb480979f14b55c7fe5/Documentation/docs/develop_requirement.md

@finetjul
Copy link
Copy Markdown
Member

finetjul commented Feb 16, 2026

Indeed, my bad, my master was outdated. 😅

After updating it, I have the following error:

Could not resolve "../../../examples/gallery.js" from "Documentation/.vitepress/theme/components/ExamplesGallery.vue"
file: C:/Work/vtk.js/vtk-js/Documentation/.vitepress/theme/components/ExamplesGallery.vue

I fix it by calling npm run docs:generate-gallery before npm run docs:build.
Maybe it should be documented somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants