Emit progress events from VtkLocal and document global loader usage#53
Merged
jourdain merged 4 commits intoKitware:masterfrom Jan 2, 2026
Merged
Conversation
jourdain
reviewed
Dec 31, 2025
jourdain
reviewed
Dec 31, 2025
jspanchu
requested changes
Dec 31, 2025
Contributor
Author
|
@jspanchu I have reverted the |
Member
|
@abhinavsns Thanks. LGTM |
Collaborator
|
Now that |
jspanchu
reviewed
Jan 1, 2026
Member
jspanchu
left a comment
There was a problem hiding this comment.
LGTM. can you bump the version of vtk-wasm in package.json and the lock file as well?
Contributor
Author
|
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Issue: #49
Linked PR: Kitware/vtk-wasm#20
Wire vtk-wasm progress into VtkLocal with an overlay during wasm load/sync; emit a progress event from the Vue component; expose progress in the Python widget and document how to drive a global app loader.
Usage (Python/trame global loader):
Usage (Vue):
<VtkLocal @progress="onProgress" />