Add failing flag when fetching externals

[edabor]

This PR checks that externals fetching url are valid.

[jourdain]

The fail flag is great, but the viewer url is wrong (should be https://kitware.github.io/vtk-js/examples/OfflineLocalView/index.html) but even then since that is not a standalone application, it won't work in the export context to trame-vtk.

[jourdain]

@jourdain use that once we can point to a valid standalone viewer.

[edabor]

The fail flag is great, but the viewer url is wrong (should be https://kitware.github.io/vtk-js/examples/OfflineLocalView/index.html) but even then since that is not a standalone application, it won't work in the export context to trame-vtk.

Understood. I removed the wrong link, but I still think that the fail flag can be useful to prevent releasing not found html links.

I updated the PR description and title accordingly.

[jourdain]

The fail flag is great, but the viewer url is wrong (should be https://kitware.github.io/vtk-js/examples/OfflineLocalView/index.html) but even then since that is not a standalone application, it won't work in the export context to trame-vtk.

Understood. I removed the wrong link, but I still think that the fail flag can be useful to prevent releasing not found html links.

I updated the PR description and title accordingly.

agree

[edabor]

... but now the wrong link prevents CI to pass (as expected) 😓
Do you have a preference between changing the OfflineViewer link or completely discarding the curl command ?

[jourdain]

I'll integrate this PR once we have a valid link. Don't worry about it for now. ;-)

Thanks for improving those curl commands.