Merged
Conversation
jourdain
reviewed
Apr 22, 2025
jourdain
reviewed
Apr 22, 2025
Contributor
|
@jourdain, it seems Vue3 does not support VSelect "header" items the same way Vue2 did. Should I add a fix here so that domains value that used the "header" key (resulting in a section in the dropdown) are interpreted the same way as in Vue2 ? |
Collaborator
Which ever is easier. I'm fine either way |
Support both 'text' and 'title' defined items in sw-select widgets
Support 'header' entries in sw-select items list to maintain support from vuetify2 syntax
Jo-Byr
force-pushed
the
handle_proxies_list_with_vue3
branch
from
834d442 to
5904d98
Compare
Contributor
|
@jourdain I removed the unnecessary ref and fixed the header problem. If you validate, I think we can merge. |
Collaborator
|
LGTM, you can merge when you want |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.