feat(life-cycle): Register on_error to LifeCycle#15
Merged
jourdain merged 1 commit intoKitware:mainfrom Dec 13, 2025
Merged
Conversation
This was referenced Dec 11, 2025
snacksbro
changed the title
on_error to LifeCycleon_error to LifeCycle
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a pair, with the other half of the changes being in trame-server.
This change exposes a new decorator for LifeCycle,
on_errorthat allows the developer to define this as a decorator (like the existing ones like@life_cycle.server_ready) so errors occurring on the client can be seen in the server.A demo example of this working is here: Kitware/trame#835 and relies both the changes in this PR and the PR in trame-server to be installed.