Add SVG filters to smooth spectrograms #251
Draft
+201
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naglepuff
commented
Oct 8, 2025
Comment on lines
+762
to
+765
| // Knobs for testing blur filters | ||
| const contrast = ref({slope: 1.2, intercept: -0.1}); | ||
| const gaussianBlur = ref({ stdDeviation: 1.5 }); | ||
| const convolutionMatrix = ref({ order: 5 }); |
Collaborator
Author
There was a problem hiding this comment.
For anyone interested in exploring this branch, I've added this reactive state to the component for ease of testing changes.
naglepuff
commented
Oct 8, 2025
| /> | ||
| </feComponentTransfer> | ||
| </filter> | ||
| <filter id="spectro-smoothing-gaussian"> |
Collaborator
Author
There was a problem hiding this comment.
Note that there are now 3 separate filters with unique ids. The filter that is currently applied is determined by code in the geoJSUtils file.
naglepuff
commented
Oct 8, 2025
Comment on lines
+124
to
+127
| // quadFeatureLayer.node().css("filter", "url(#apply-color-scheme)"); | ||
| // quadFeatureLayer.node().css("filter", "url(#spectro-smoothing-gaussian)"); | ||
| // quadFeatureLayer.node().css("filter", "url(#spectro-smoothing-convo)"); | ||
| quadFeatureLayer.node().css("filter", "url(#spectro-smoothing-combined)"); |
Collaborator
Author
There was a problem hiding this comment.
Commented-out lines here refer to other filters. Currently the filter combines both techniques (gaussian blur and convolution matrix). For those interested, you can pick a different filter to use to compare.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.