python: Port cpp tests and add examples#2
Open
jspanchu wants to merge 5 commits into
Open
Conversation
jspanchu
added a commit
to Kitware/trame-rca
that referenced
this pull request
Jun 12, 2026
- resizing the frame is sufficient for the encoder to realize that it should shutdown existing session and open a new encoding session. - there was a bug upstream where setting width/height on the encoder did not bump the MTime of the encoder and so, the frame size was equal to the encoder size and the responsibility of re-initializing the context fell on the MTime logic which was flawed because the encoder did not bump the MTime. As a result, this code needed to manually call `_reset`. - this has been fixed upstream in Kitware/VTKStreaming#2, so I'm changing the code here.
jspanchu
added a commit
to Kitware/trame-rca
that referenced
this pull request
Jun 12, 2026
- resizing the frame is sufficient for the encoder to realize that it should shutdown existing session and open a new encoding session. - there was a bug upstream where setting width/height on the encoder did not bump the MTime of the encoder and so, the frame size was equal to the encoder size and the responsibility of re-initializing the context fell on the MTime logic which was flawed because the encoder did not bump the MTime. As a result, this code needed to manually call `_reset`. - this has been fixed upstream in Kitware/VTKStreaming#2, so I'm changing the code here.
jspanchu
added a commit
to Kitware/trame-rca
that referenced
this pull request
Jun 12, 2026
- resizing the frame is sufficient for the encoder to realize that it should shutdown existing session and open a new encoding session. - there was a bug upstream where setting width/height on the encoder did not bump the MTime of the encoder and so, the frame size was equal to the encoder size and the responsibility of re-initializing the context fell on the MTime logic which was flawed because the encoder did not bump the MTime. As a result, this code needed to manually call `_reset`. - this has been fixed upstream in Kitware/VTKStreaming#2, so I'm changing the code here.
Justineantoine
pushed a commit
to Kitware/trame-rca
that referenced
this pull request
Jun 15, 2026
- resizing the frame is sufficient for the encoder to realize that it should shutdown existing session and open a new encoding session. - there was a bug upstream where setting width/height on the encoder did not bump the MTime of the encoder and so, the frame size was equal to the encoder size and the responsibility of re-initializing the context fell on the MTime logic which was flawed because the encoder did not bump the MTime. As a result, this code needed to manually call `_reset`. - this has been fixed upstream in Kitware/VTKStreaming#2, so I'm changing the code here.
jspanchu
force-pushed
the
port-cpp-tests-to-python
branch
from
615f246 to
8b7e64d
Compare
jourdain
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.