Open
Conversation
Add run script for building server and running client tests
ianpartridge
reviewed
Oct 4, 2019
|
|
||
| WORKDIR /WebSocketEchoServer | ||
|
|
||
| RUN swift build |
Contributor
There was a problem hiding this comment.
Release mode? Or not...
Contributor
Author
There was a problem hiding this comment.
Hmm good question. I'd gone for debug mode since we're dealing with tests, but as this is essentially acceptance testing, perhaps it should be release mode.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing Kitura-WebSocket, I wanted to run the Autobahn tests against my changes. The existing guide in
AutobahnTests.mdis helpful, but it's a pain to have to install all the dependencies for the client, deal with versions of Python, missing macOS headers and so on.I found that there's an autobahn docker image (https://github.com/crossbario/autobahn-testsuite/tree/master/docker) that we can use for the client. And we can do everything within Docker if we dockerize the echo server and run both on a network.
To that end, I've created an
Autobahnsubproject containing a Dockerfile and arun.shwhich wil build the server into awsserverimage, run that as a container on a Docker network calledautobahn, and then run the autobahn client (on the same network) targettingwsserver:9001. At the end of the run, it'll open the HTML report that the client generates.