adding 'to-string' function

[esr360]

So I just realised that SassyJSON does not come with your 'to-string' function - I just happened to already be using it for something else which is why it worked for me. And of course my previous pull-request relies on this function.

I've tried to be as consistent as possible when creating the new file but please let me know if you need any changes.

[KittyGiraudel]

I believe we should just use https://github.com/HugoGiraudel/SassyJSON/blob/master/stylesheets/encode/types/_string.scss.

[esr360]

Hmm, that uses the "_proof-quote" function, which is the function in which we are trying to convert the value to a string. As a result, I'm getting "SystemStackError: stack level too deep".

[KittyGiraudel]

Ouch... That doesn't sound to good. I will have a closer look.

Le mar. 8 sept. 2015 21:28, Edmund notifications@github.com a écrit :

Hmm, that uses the "_proof-quote" function, which is the function in which
we are trying to convert the value to a string. As a result, I'm getting
"SystemStackError: stack level too deep".

—
Reply to this email directly or view it on GitHub
#84 (comment)
.

[KittyGiraudel]

Should be ''.

[KittyGiraudel]

Too large indentation, I'd say?

[esr360]

I've made the requested changes, and it's working perfectly on my local project.

Just one thing regarding this updated line:

$result + #{$e} + #{$glue}, $result#{$e}

Perhaps this is expected, but this doesn't work:

$result + #{$e} + #{$glue}, $result + #{$e}

It outputs the '+' symbol.

[KittyGiraudel]

If you concatenate with +, don't interpolate.

[esr360]

Ok, I think we got there :)

My butchered attempt at concatenating was causing issues when using '' instead of null for the $result. Fixing the concatenation consequently meant that using $result: ''; now works as expected (and vice versa - the presence of $result: null was messing up the concatenation - both needed to be done simultaneously).

[KittyGiraudel]

Weird, a test is failing.

[KittyGiraudel]

No need for interpolation here. :)

[KittyGiraudel]

$is-nested and $recursive should be passed rather than true and true.

[esr360]

Done and done :) Test still seems to be failing though?

Cheers

[KittyGiraudel]

Not quite sure why... Might be just the linting.

[KittyGiraudel]

Actually I have been double-checking this and I think we don't need this to-string at all. The proof-quote function is only called in safe circumstances where the value can be safely quoted without having to be stringified first.

[esr360]

o_O Well my project still works as expected after removing this, but I was definitely having issues which converting the value to a string fixed. I can't right now replicate it, but I believe it was when trying to pass a value of 'null' to the function, resulting in 'Invalid null operation: """ plus null".'.

[KittyGiraudel]

For now I'd say the only thing we need is getting rid of this to-string(..) call.