Conversation
Member
Merkost
commented
Dec 22, 2025
- feat: Update build configuration for Kotlin Multiplatform and enhance Android library support
- feat: Replace Cedar logging with KurrencyLog for improved logging consistency
- feat: Remove composeHotReload plugin for cleaner build configuration
…Hub Actions checkout version
There was a problem hiding this comment.
Pull request overview
This pull request modernizes the build configuration for Kotlin Multiplatform and introduces a logging abstraction layer. The changes involve removing the composeHotReload plugin, migrating from direct Cedar logging calls to a new KurrencyLog wrapper, updating dependency versions, and restructuring the Android library configuration to use the new androidKotlinMultiplatformLibrary plugin.
Key Changes:
- Removal of
composeHotReloadplugin from build configuration - Introduction of
KurrencyLoggingabstraction layer that wraps Cedar logging with configurable enablement - Migration to
androidKotlinMultiplatformLibraryplugin with inline Android configuration in Kotlin DSL - Version updates for Kotlin (2.2.21 → 2.3.0), AGP (8.13.1 → 8.13.2), and various AndroidX libraries
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| sample/build.gradle.kts | Removes composeHotReload plugin reference |
| build.gradle.kts | Removes composeHotReload plugin from root configuration |
| gradle/libs.versions.toml | Updates Kotlin, AGP, and AndroidX versions; removes composeHotReload plugin definition |
| kurrency-core/build.gradle.kts | Major restructuring: switches to androidKotlinMultiplatformLibrary plugin, moves Android config inline, changes Cedar from api to implementation, disables signing |
| kurrency-compose/build.gradle.kts | Switches to androidKotlinMultiplatformLibrary plugin and moves Android config inline |
| kurrency-core/src/commonMain/kotlin/org/kimplify/kurrency/KurrencyLogging.kt | Adds new logging abstraction layer with KurrencyLog wrapper around Cedar |
| kurrency-core/src/*/kotlin/org/kimplify/kurrency/CurrencyFormatterImpl.kt | Migrates all Cedar logging calls to KurrencyLog across all platform implementations (Android, iOS, JVM, JS, WasmJS) |
| kurrency-core/src/commonMain/kotlin/org/kimplify/kurrency/CurrencyState.kt | Migrates Cedar logging calls to KurrencyLog |
| kurrency-core/src/commonMain/kotlin/org/kimplify/kurrency/CurrencyMetadata.kt | Migrates Cedar logging calls to KurrencyLog |
| kurrency-core/src/commonMain/kotlin/org/kimplify/kurrency/CurrencyFormatter.kt | Migrates Cedar logging calls to KurrencyLog |
Comments suppressed due to low confidence (2)
kurrency-core/build.gradle.kts:93
- The
signAllPublications()call has been commented out. This means artifacts will be published without signatures, which is typically required for Maven Central publication. If this is intentional for development/testing purposes, consider adding a comment explaining why signing is disabled. Otherwise, this should be re-enabled before publishing to Maven Central.
signAllPublications()
kurrency-compose/build.gradle.kts:77
- The
signAllPublications()call has been commented out. This means artifacts will be published without signatures, which is typically required for Maven Central publication. If this is intentional for development/testing purposes, consider adding a comment explaining why signing is disabled. Otherwise, this should be re-enabled before publishing to Maven Central.
signAllPublications()
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.