Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces an initial currency formatting implementation for a Kotlin Multiplatform library called "Kurrency". However, the PR contains numerous unresolved merge conflicts across multiple files that prevent it from being merged.
Key additions include:
- Core currency formatting functionality with platform-specific implementations (Android, iOS, JVM, web)
- Compose UI integration with CurrencyState
- Comprehensive test suite (92 tests)
- Sample applications and documentation
- CI/CD workflows for build and publish
Reviewed Changes
Copilot reviewed 30 out of 33 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Multiple source files (main.kt, AndroidManifest.xml, build.gradle.kts) | Contains unresolved merge conflicts |
| kurrency-core/src/*/CurrencyFormatterImpl.kt | Platform-specific currency formatting implementations |
| kurrency-core/src/commonMain/kotlin/*.kt | Core currency classes and error handling |
| kurrency-core/src/commonTest/kotlin/*.kt | Comprehensive test suite |
| sample/src/commonMain/kotlin/*.kt | Sample applications demonstrating usage |
| gradle configuration files | Contains merge conflicts in version and dependency management |
| README.md | Contains merge conflicts in documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…update CI configuration
…build configuration for Maven publishing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.