Some tweaks to simplify firing MobSpawnEvent.FinalizeSpawn from Kilt#13
Closed
Acuadragon100 wants to merge 5 commits into
Closed
Some tweaks to simplify firing MobSpawnEvent.FinalizeSpawn from Kilt#13Acuadragon100 wants to merge 5 commits into
Acuadragon100 wants to merge 5 commits into
Conversation
This might fire the event again if some forge mod uses `@ModifyReceiver` in `ForgeEventFactory::onFinalizeSpawn`, but will make sure that running `finalizeSpawn` on a new mob from `finalizeSpawn` will work as expected.
This should make sure the finalize event is only fired once per entity.
Member
|
In theory, wouldn't these changes be possible as a mixin workaround? I feel like it would be preferred so we remember to port these changes between versions. |
Author
|
Wait, so basically close this pull request and move everything into KiltMC/Kilt#789? |
Member
|
Yeah pretty much |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed by KiltMC/Kilt#789