feat(vscode, cli): add system prompt inspection#7814
Closed
marius-kilocode wants to merge 5 commits intomainfrom
Closed
feat(vscode, cli): add system prompt inspection#7814marius-kilocode wants to merge 5 commits intomainfrom
marius-kilocode wants to merge 5 commits intomainfrom
Conversation
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Contributor
Code Review SummaryStatus: 2 Issues Found | Recommendation: Address before merge Overview
Fix these issues in Kilo Cloud Issue Details (click to expand)WARNING
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (12 files)
Reviewed by gpt-5.4-20260305 · 2,560,251 tokens |
Add a 'Show System Prompt' button (glasses icon) in the VS Code extension chat header that lets users inspect the full assembled system prompt with source metadata. - Server: GET /session/:sessionID/system-prompt endpoint that assembles the prompt and returns each section (soul, provider, environment, instruction files) with provenance metadata - SDK: regenerated client.session.systemPrompt() method - Extension: KiloProvider handler + SystemPromptView component with collapsible sections, expand/collapse all, and copy
- Overlay layout: render panel inside messages area with absolute positioning so it never shifts the prompt input - Session awareness: re-fetch on session switch, key responses by sessionID to prevent stale data from wrong session - Workspace directory: pass directory for worktree session support - Copy feedback: icon swaps to checkmark with green color for 1.5s - i18n: add translated keys for all 18 locales (expand/collapse/copy/copied) - Move promptOpen state from TaskHeader to ChatView
marius-kilocode
force-pushed
the
spectacular-artichoke
branch
from
56401e4 to
8b0d774
Compare
# Conflicts: # packages/kilo-vscode/webview-ui/src/types/messages.ts
markijbema
reviewed
Mar 30, 2026
| * Uses VS Code CSS variables for theming | ||
| */ | ||
|
|
||
| /* ============================================ |
Contributor
There was a problem hiding this comment.
should we have a css file per components? this css file is becoming quite unwieldy
markijbema
requested changes
Mar 30, 2026
|
|
||
| /** | ||
| * Assemble the full system prompt with source metadata. | ||
| * Mirrors the assembly in LLM.stream() + SessionPrompt.loop() |
Contributor
There was a problem hiding this comment.
this fels tricky, how can we be sure this keeps in sync. I think if we dont actually reuse the logic this will only give peolpe a false feeling of safety/understanding
…y, extract CSS - Extract SystemPrompt.header() used by both LLM.stream() and the inspection endpoint, eliminating duplicated assembly logic (Mark's review comment) - Extract system-prompt.css from chat.css (Mark's review comment) - Remove sources metadata - endpoint returns flat system[] array matching what LLM.stream() builds - Simplify SystemPromptView to render segments directly - Close panel when session is cleared (bot comment) - Remove SystemPromptSource type
| const identity = SystemPrompt.header({ model, agent }) | ||
| const env = await SystemPrompt.environment(model, editorContext) | ||
| const instructions = await InstructionPrompt.system() | ||
| const system = [identity, ...env, ...instructions] |
Contributor
There was a problem hiding this comment.
WARNING: This endpoint still does not mirror the prompt sent to the model
SessionPrompt.loop() builds input.system from environment() and InstructionPrompt.system(), and LLM.stream() folds that array into SystemPrompt.header(...extra), so the model receives a single combined system string. Returning [identity, ...env, ...instructions] here means the inspector/copy view can still drift from what the model actually saw.
markijbema
reviewed
Mar 30, 2026
| agent: input.agent, | ||
| codex: isCodex, | ||
| extra: [...input.system, ...(input.user.system ? [input.user.system] : [])], | ||
| }), |
Contributor
There was a problem hiding this comment.
I like it better, but it is trickier to merge
markijbema
approved these changes
Mar 30, 2026
Collaborator
Author
|
@markijbema The technical debt might not be worth the feature. Let's reiterate on this later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
GET /session/:sessionID/system-promptendpoint that assembles the prompt with source metadata viaSystemPrompt.inspect()client.session.systemPrompt()methodrequestSystemPromptmessage handler inKiloProviderSystemPromptViewcomponent, button inTaskHeader, message types, CSSHow to test