fix(cli): default Gateway MiniMax M3 to adaptive thinking#11562
fix(cli): default Gateway MiniMax M3 to adaptive thinking#11562lambertjosh wants to merge 2 commits into
Conversation
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| result["thinking"] = { type: "adaptive" } | ||
| } | ||
| // kilocode_change start - match MiniMax M3's adaptive default through Kilo Gateway | ||
| if (modelId.includes("minimax-m3") && input.model.api.npm === "@kilocode/kilo-gateway") { |
There was a problem hiding this comment.
SUGGESTION: Keep the Gateway-specific override out of the shared upstream file
This branch only applies to @kilocode/kilo-gateway, so it seems worth moving the behavior into a helper under packages/opencode/src/kilocode/... and calling that helper from here behind a single hook. Keeping Kilo-only provider logic inline in packages/opencode/src/provider/transform.ts grows the fork delta in a file we regularly merge from upstream.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Code Review SummaryStatus: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (3 files)
Previous Review Summary (commit 203fdfa)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 203fdfa)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (3 files)
Reviewed by gpt-5.4-20260305 · Input: 66.9K · Output: 6.8K · Cached: 137.6K Review guidance: REVIEW.md from base branch |
|
LGTM! |
| expect(kiloProviderOptions(options).anthropic.thinking).toEqual({ type: "adaptive" }) | ||
| }) | ||
|
|
||
| test("allows the instant variant to disable thinking", () => { |
There was a problem hiding this comment.
SUGGESTION: Renamed test still exercises the old none knob
This rename makes the test read like it covers the user-facing instant option, but the setup below still disables thinking through reasoning.effort = "none". If the cloud-side instant mapping ever drifts, this test will keep passing while the documented contract breaks. It would be safer to build the options the same way the instant catalog entry does, or assert that translation point directly.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
2 participants
Summary
Default MiniMax M3 requests through Kilo Gateway to adaptive thinking, matching the direct Anthropic provider behavior merged from upstream. The cloud model catalog keeps the common Gateway labels
thinkingandinstant; selectinginstantoverrides this default and sends disabled thinking.This is the CLI companion to Kilo-Org/cloud#4188.