Bitbucket - Add Bitbucket Integration#4218
Conversation
| const onlyAvailableRepo = | ||
| !isLoadingGitHubRepos && | ||
| !isLoadingGitLabRepos && | ||
| (organizationId || !isLoadingBitbucketRepos) && |
There was a problem hiding this comment.
WARNING: Repository auto-selection can race Bitbucket loading
For personal sessions this effect still runs while the Bitbucket query is loading, and for organization sessions organizationId || !isLoadingBitbucketRepos explicitly treats the repository set as complete before Bitbucket finishes. Because getPreferredInitialRepo() still only tracks GitHub/GitLab loading, a saved or recent GitHub/GitLab repo can be auto-selected here and prevent the user’s Bitbucket repo from ever being chosen automatically.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
| CREATE UNIQUE INDEX "UQ_platform_oauth_credentials_platform_integration_id" ON "platform_oauth_credentials" USING btree ("platform_integration_id");--> statement-breakpoint | ||
| CREATE INDEX "IDX_platform_oauth_credentials_platform_subject" ON "platform_oauth_credentials" USING btree ("platform","provider_subject_id");--> statement-breakpoint | ||
| CREATE INDEX "IDX_platform_oauth_credentials_authorized_by_user_id" ON "platform_oauth_credentials" USING btree ("authorized_by_user_id");--> statement-breakpoint | ||
| CREATE UNIQUE INDEX "UQ_platform_integrations_user_bitbucket" ON "platform_integrations" USING btree ("owned_by_user_id","platform") WHERE "platform_integrations"."platform" = 'bitbucket' AND "platform_integrations"."owned_by_user_id" IS NOT NULL;--> statement-breakpoint |
There was a problem hiding this comment.
WARNING: Non-concurrent index creation can block writes on deploy
platform_integrations is an existing populated table, so these two CREATE UNIQUE INDEX statements will take a write-blocking lock while the migration runs. In production that can stall integration updates and other writes; this needs a concurrent rollout strategy instead of plain index creation.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Previous Review Summary (commit 95af145)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 95af145)Status: 2 Issues Found | Recommendation: Address before merge Fix these issues in Kilo Cloud Overview
Issue Details (click to expand)WARNING
Files Reviewed (103 files)
Reviewed by gpt-5.4-20260305 · Input: 84.9K · Output: 8.3K · Cached: 549.6K Review guidance: REVIEW.md from base branch |
Summary
git-token-service, with live owner authorization checks and purpose-bound internal tokens.Verification