-
Notifications
You must be signed in to change notification settings - Fork 46
docs(design): align token contract and skill #4169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+421
−410
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| # Kilo Design Skill Maintenance | ||
|
|
||
| ## Purpose | ||
|
|
||
| Keep frontend design work aligned with root `DESIGN.md` while translating its contract into practical web, mobile, Storybook, accessibility, responsive, interaction, motion, and UX-writing guidance. | ||
|
|
||
| ## How the skill works | ||
|
|
||
| 1. `SKILL.md` loads root `DESIGN.md` first. | ||
| 2. `reference/kilo-brand.md` maps the contract to repository implementation. | ||
| 3. Concern-specific references add focused guidance without redefining tokens. | ||
| 4. Existing CSS and components are implementation evidence, not higher-priority sources. Differences from `DESIGN.md` are drift. | ||
|
|
||
| ## Validation | ||
|
|
||
| After changing this skill: | ||
|
|
||
| - Search all skill Markdown for retired token values and stale implementation claims. | ||
| - Check compact Markdown table padding with `bun run script/check-md-table-padding.ts`. | ||
| - Run `git diff --check` for changed skill files. | ||
|
|
||
| ## Change guidelines | ||
|
|
||
| - Update root `DESIGN.md` before changing canonical token names, values, domain mappings, typography metrics, radius, or spacing. | ||
| - Keep exact token values in `DESIGN.md`; references should link roles to implementation and avoid duplicating the full contract. | ||
| - Preserve Kilo-specific defaults: dark-first product UI, one primary CTA per surface, six-role surface ladder, fixed status domains, Inter/Roboto Mono roles, compact rhythm, Radix/shadcn primitives, restrained motion, and direct UX copy. | ||
| - When implementation migrates, remove stale warnings immediately. Do not preserve resolved issues as historical guidance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.