fix: redirect unauthenticated users from subscriptions page#4137
Open
FaisalMisbah23 wants to merge 1 commit into
Open
fix: redirect unauthenticated users from subscriptions page#4137FaisalMisbah23 wants to merge 1 commit into
FaisalMisbah23 wants to merge 1 commit into
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by gpt-5.4-20260305 · Input: 63K · Output: 5.8K · Cached: 322K Review guidance: REVIEW.md from base branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix unauthenticated access handling for the subscriptions page.
Previously, a logged-out user could navigate directly to
/subscriptions. The page would render and then display an authentication error after a subscription-related API request returned 401.This change adds an authentication check at the subscriptions layout level using
getUserFromAuthOrRedirect(), ensuring unauthenticated users are redirected before subscription content is rendered.Fixes #4136
Verification
/subscriptionsVisual Changes
N/A
Reviewer Notes
This change applies the authentication guard at the layout level so all routes under
/subscriptionsrequire authentication before rendering.