chore(dev): cloud reviews local testing E2E#4133
Conversation
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| const appType = integration.github_app_type ?? 'standard'; | ||
| const headFullName = checkoutRef.headRepoFullName ?? repository.full_name; | ||
| const [headOwner, headRepoName] = headFullName.split('/'); | ||
| const useLocalFakeProvider = isLocalCodeReviewFakeProviderEnabled(); |
There was a problem hiding this comment.
WARNING: Local fake mode still reaches GitHub on synchronize
useLocalFakeProvider is only consulted after shouldSkipSynchronizeForMergeCommit() runs. On pull_request.synchronize, that helper still calls isMergeCommit(), which generates an installation token and hits git.getCommit. This breaks the CODE_REVIEW_LOCAL_FAKE_PROVIDER=1 contract of avoiding real provider access, so replaying captured synchronize payloads can still fail against the seeded fake integration.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
|
|
||
| // 8. Resolve checkout ref (fork MRs use refs/merge-requests/<iid>/head) | ||
| const { checkoutRef } = resolveMergeRequestCheckoutRef(payload); | ||
| const useLocalFakeProvider = isLocalCodeReviewFakeProviderEnabled(); |
There was a problem hiding this comment.
WARNING: Local fake mode still reaches GitLab on update paths
useLocalFakeProvider is only computed after the earlier update-path provider calls. merge_request.update still runs getValidGitLabToken() and isMergeCommit(), and the cancelled-review cleanup above can still call getOrCreateProjectAccessToken() plus setCommitStatus() before this guard is checked. That means the fake-provider workflow can still require a real GitLab token and instance even though this mode is documented as avoiding provider API access.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Code Review SummaryStatus: 2 Issues Found | Recommendation: Address before merge Fix these issues in Kilo Cloud Overview
Issue Details (click to expand)WARNING
Files Reviewed (20 files)
Reviewed by gpt-5.4-20260305 · Input: 192.9K · Output: 20.2K · Cached: 2.7M Review guidance: REVIEW.md from base branch |
alex-alecu
changed the title
1 participant
Summary
dev/AGENTS.md.Verification
Visual Changes
N/A
Reviewer Notes
CODE_REVIEW_LOCAL_FAKE_PROVIDER=1; production provider behavior is unchanged.dev/review/fixtures/*.jsonis intentionally tracked despite the broader dev fixture ignore rule.