Skip to content

ci(cloud-agent-next): add staging worker config#4117

Closed
RSO wants to merge 9 commits into
mainfrom
cloud-agent-staging
Closed

ci(cloud-agent-next): add staging worker config#4117
RSO wants to merge 9 commits into
mainfrom
cloud-agent-staging

Conversation

@RSO

@RSO RSO commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds an explicit staging Wrangler environment for services/cloud-agent-next so it can participate in the staging Worker deployment matrix without reusing production routes, queues, R2 buckets, or container capacity.

Verification

Manual verification was limited to local config inspection and Wrangler dry-run behavior; live Cloudflare resource checks were blocked because local Wrangler auth does not have access to the configured Kilo Cloudflare account.

Visual Changes

N/A

Reviewer Notes

This PR targets foamy-drip so the diff only contains the cloud-agent-next staging configuration layered on top of the staging deployment workflow PR.

The staging config points service bindings at staging-named dependencies (session-ingest-staging, git-token-service-staging, notifications-staging) so staging traffic is not silently routed to production workers. Those dependency deployments must exist before a live deploy can fully succeed.

Comment thread services/cloud-agent/wrangler.jsonc Outdated
"bucket_name": "kilocode-sessions-staging",
},
],
"hyperdrive": [],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: Staging loses GitHub App installation lookup

This env removes the HYPERDRIVE binding, but prepareSession only resolves repository installations when Hyperdrive is configured (services/cloud-agent/src/router/handlers/session-prepare.ts, lines 96-144). Any staging caller that sends githubRepo without an explicit githubToken will now fail with GitHub token or active app installation required for this repository, so repo-backed staging sessions won't behave like production.


Reply with @kilocode-bot fix it to have Kilo Code address this issue.

@kilo-code-bot

kilo-code-bot Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • services/cloud-agent-next/wrangler.jsonc
  • services/cloud-agent/wrangler.jsonc
Previous Review Summary (commit b82c40c)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit b82c40c)

Status: 1 Issue Found | Recommendation: Address before merge

Fix these issues in Kilo Cloud

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
services/cloud-agent/wrangler.jsonc 231 Staging omits Hyperdrive, so prepareSession cannot resolve GitHub App installations for callers that do not pass a githubToken.
Other Observations (not in diff)

No additional findings outside the diff.

Files Reviewed (1 files)
  • services/cloud-agent/wrangler.jsonc - 1 issue

Reviewed by gpt-5.4-20260305 · 171,344 tokens

Review guidance: REVIEW.md from base branch main

Base automatically changed from foamy-drip to main June 19, 2026 07:15
@RSO RSO changed the title ci(cloud-agent): add staging worker config ci(cloud-agent-next): add staging worker config Jun 19, 2026
@RSO

RSO commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

Closing in favor of #4118, which is based directly on main and contains only the cloud-agent-next staging config change.

@RSO RSO closed this Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant