Open
Conversation
Owner
|
Thank you, I like it, seems like a good feature to me! I'll review your PR on Monday. |
Author
|
fixed fmt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a project I have, I need to input the private key in a GitLab protected CI/CD pipeline variable, and in GitLab, variables are entered in a web text input field, so copy and pasting the current "binary" key file is not working.
I thought of converting it to base64, and then converting it back in my pipeline but it was kind of kludgy, and it then hit me that is what the PEM format is all about, having a simple header/footer, and the encoded content in base64 inside.
I don't think I changed the zipsign-api public API, so it should not break any existing code when upgrading.
A quick
cargo build -ron main and on the pem branch tells me this adds ~21kB to the resulting cli: