Skip to content

Simplify aws bulk send interface #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ToQoz wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Simplify aws bulk send interface #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa1412b
breaking: simplify awsBulkSend interface
ToQoz Jun 13, 2022
7420e83
Bump version of @kidscannon/aws-bulk-send
ToQoz Jun 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions packages/aws-bulk-send/__tests__/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,18 +37,9 @@ describe('awsBulkSend', () => {
})

expect(res).toEqual([
[
{ Bucket: 'B1', Key: 'K1' },
{ $metadata, Body: 'B1-K1' },
],
[
{ Bucket: 'B3', Key: 'K3' },
{ $metadata, Body: 'B3-K3' },
],
[
{ Bucket: 'B2', Key: 'K2' },
{ $metadata, Body: 'B2-K2' },
],
{ $metadata, Body: 'B1-K1' },
{ $metadata, Body: 'B3-K3' },
{ $metadata, Body: 'B2-K2' },
])
})
})
Expand All @@ -59,7 +50,7 @@ describe('awsBulkSendT', () => {
const res = await awsBulkSendT({
client,
transformer: (input, output: GetObjectCommandOutput) => {
return { $metadata, Body: `transformed-${output.Body}` }
return [input, { $metadata, Body: `transformed-${output.Body}` }]
},
commands: [
new GetObjectCommand({ Bucket: 'B1', Key: 'K1' }),
Expand Down
8 changes: 4 additions & 4 deletions packages/aws-bulk-send/lib/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ export const awsBulkSend = async <Input, Output>({
client: Client<Input, Output>
commands: Command<Input, Output, unknown>[]
options?: { concurrency?: number }
}): Promise<[Input, Output][]> => {
}): Promise<Output[]> => {
const limit = pLimit(options?.concurrency ?? 1000)
return Promise.all(commands.map(async (cmd) => [cmd.input, await limit(() => client.send(cmd))]))
return Promise.all(commands.map((cmd) => limit(() => client.send(cmd))))
}

export const awsBulkSendT = async <Input, Output, TransformedOutput>({
Expand All @@ -28,9 +28,9 @@ export const awsBulkSendT = async <Input, Output, TransformedOutput>({
commands: Command<Input, Output, unknown>[]
transformer: (input: Input, output: Output) => TransformedOutput
options?: { concurrency?: number }
}): Promise<[Input, TransformedOutput][]> => {
}): Promise<TransformedOutput[]> => {
const limit = pLimit(options?.concurrency ?? 1000)
return Promise.all(
commands.map(async (cmd) => [cmd.input, await limit(async () => transformer(cmd.input, await client.send(cmd)))]),
commands.map((cmd) =>limit(async () => transformer(cmd.input, await client.send(cmd)))),
)
}
2 changes: 1 addition & 1 deletion packages/aws-bulk-send/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@kidscannon/aws-bulk-send",
"version": "0.0.3",
"version": "0.0.4",
"description": "aws bulk send",
"keywords": [
"aws",
Expand Down