increase useability of the repo#8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the CharmKiT-side accessibility and usability gaps from
kitrt_accessibility_usability_plan.mdafter checking that they still existed locally.Verified Gaps And Changes
ScSteffen/charm_kitclone URL and referencedinstall_KiT-RT.sh/update_KiT-RT.sh. Updated the README to useKiT-RT/CharmKiT,install_kitrt.sh, andupdate_kitrt.sh, and added a short decision guide for when to use CharmKiT versuskitrt_code.pyproject.tomlhadpackage-mode = falseand no console script. Added package metadata,src/__init__.py, and acharm-kitentry point backed bysrc/cli.py.charm-kit run <case>andcharm-kit submit <case>dispatch for lattice and hohlraum while keeping the existing scripts working.install_kitrt.shto detect Apptainer/Singularity, reuse existing SIFs, optionally pull CPU/CUDA images, supportKITRT_CONTAINER_BUILD=skip|fakeroot|sudo|auto, and reuse an existingkitrt_codecheckout.update_kitrt.shand unignored it in.gitignoreso it appears in the PR.--slurm --cudawas blocked: removed that blocker and added SLURM CUDA script generation using the CUDA SIF,--nv, andKITRT_CUDA_MPI_RANKS/SLURM_GPUS_ON_NODErank selection.KITRT_CONTAINER_RUNTIMEsupport for local and generated SLURM container commands.charm-kit, SLURM CUDA generation, and runner/model CUDA propagation.Primary Files
README.md.gitignorepyproject.tomlsrc/__init__.pysrc/cli.pyinstall_kitrt.shupdate_kitrt.shslurm_template.shsrc/config_utils.pysrc/simulation_utils.pysrc/models/lattice.pysrc/models/hohlraum.pyrun_lattice.pyrun_hohlraum.pytests/test_charm_kit_cli.pytests/test_config_utils.pytests/test_cli_and_runner_flags.pytests/test_model_operations.pyVerification
python3 -m py_compile run_lattice.py run_hohlraum.py src/cli.py src/config_utils.py src/simulation_utils.py src/models/lattice.py src/models/hohlraum.py tests/test_charm_kit_cli.py tests/test_config_utils.py tests/test_simulation_utils.pypython3 -m pytest -q->32 passedpoetry check-> exit 0 with deprecation warnings for legacy Poetry metadata and[tool.poetry.scripts]python3 -c "from src.cli import main; raise SystemExit(main(['--help']))"poetry run charm-kit --help-> exit 0; Poetry warns the script is not installed untilpoetry installis rerungit diff --checkNot Included
kitrt_code/,out_cpu.txt,out_cuda.txt, andtimings.txtfiles were left untouched.