Skip to content

Add support for GL_NV_explicit_typecast.#4161

Merged
dnovillo merged 2 commits intoKhronosGroup:mainfrom
alelenv:nv_typecast
Feb 3, 2026
Merged

Add support for GL_NV_explicit_typecast.#4161
dnovillo merged 2 commits intoKhronosGroup:mainfrom
alelenv:nv_typecast

Conversation

@alelenv
Copy link
Copy Markdown
Contributor

@alelenv alelenv commented Jan 23, 2026

GLSL spec here : KhronosGroup/GLSL#304

Glslang only change, no changes required for SPIRV Headers / Tools

@arcady-lunarg
Copy link
Copy Markdown
Contributor

Since the spec specifically calls out (vec3) (1, 2, 3) as something that's likely to give undesirable results, would it be possible to warn in that case? That seems like it would be a good way to let users know that their code is probably not doing what they want.

@arcady-lunarg arcady-lunarg self-requested a review January 23, 2026 21:37
@alelenv
Copy link
Copy Markdown
Contributor Author

alelenv commented Jan 27, 2026

@arcady-lunarg : Added a warning on accidental usage of sequence as operand to unary typecast

Copy link
Copy Markdown
Contributor

@arcady-lunarg arcady-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arcady-lunarg arcady-lunarg added the kokoro:run Trigger Google bot runs label Jan 29, 2026
@kokoro-team kokoro-team removed the kokoro:run Trigger Google bot runs label Jan 29, 2026
@alelenv
Copy link
Copy Markdown
Contributor Author

alelenv commented Feb 3, 2026

@arcady-lunarg or @dnovillo : Review has been approved so can either of you merge?

Thanks

@dnovillo
Copy link
Copy Markdown
Collaborator

dnovillo commented Feb 3, 2026

@arcady-lunarg or @dnovillo : Review has been approved so can either of you merge?

Thanks

Done.

@dnovillo dnovillo merged commit 968eb87 into KhronosGroup:main Feb 3, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants