gpuav: Validate BLAS ref alignment in TLAS build #11518
Merged
+202
−190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
CI Vulkan-ValidationLayers build queued with queue ID 627784. |
Collaborator
|
CI Vulkan-ValidationLayers build # 22232 running. |
| switch (error_sub_code) { | ||
| case kErrorSubCode_PreBuildAccelerationStructures_BlasAddrAlignment: { | ||
| skip |= gpuav.LogError("VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-03717", objlist, loc_with_debug_region, | ||
| "%s is not aligned to 16 bytes.", invalid_blas_loc_str.c_str()); |
Contributor
There was a problem hiding this comment.
is there a way to get the blas_addr out of the shader and print the address here?
Contributor
Author
There was a problem hiding this comment.
it gets printed in invalid_blas_loc_str!
Collaborator
|
CI Vulkan-ValidationLayers build # 22232 passed. |
spencer-lunarg
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.