Skip to content

Fix timeline semaphore value counts #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gpx1000 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix timeline semaphore value counts #293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions attachments/32_ecosystem_utilities.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1632,19 +1632,19 @@ class HelloTriangleApplication
std::array<vk::Semaphore, 2> signalSemaphores = {*renderFinishedSemaphores[imageIndex], *timelineSemaphore};
std::array<uint64_t, 2> signalValues = {0, signalValue}; // Binary semaphore value is ignored

timelineInfo.waitSemaphoreValueCount = 1; // Only for the timeline semaphore
timelineInfo.pWaitSemaphoreValues = &waitValues[1];
timelineInfo.signalSemaphoreValueCount = 1; // Only for the timeline semaphore
timelineInfo.pSignalSemaphoreValues = &signalValues[1];
timelineInfo.waitSemaphoreValueCount = 2;
timelineInfo.pWaitSemaphoreValues = waitValues.data();
timelineInfo.signalSemaphoreValueCount = 2;
timelineInfo.pSignalSemaphoreValues = signalValues.data();

vk::SubmitInfo submitInfo{
.pNext = &timelineInfo,
.waitSemaphoreCount = 1, // Only wait on the binary semaphore
.pWaitSemaphores = &waitSemaphores[0],
.pWaitDstStageMask = &waitStages[0],
.waitSemaphoreCount = 2,
.pWaitSemaphores = waitSemaphores.data(),
.pWaitDstStageMask = waitStages.data(),
.commandBufferCount = 1,
.pCommandBuffers = &*commandBuffers[frameIndex],
.signalSemaphoreCount = 2, // Signal both semaphores
.signalSemaphoreCount = 2,
.pSignalSemaphores = signalSemaphores.data()};

queue.submit(submitInfo, *inFlightFences[frameIndex]);
Expand Down
Loading