Zero-initialize InstanceExtensionProperties #1830
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkEnumerateInstanceExtensionProperties can fail to initialize ext_props in loader_add_instance_extensions(), in which case wsi_unsupported_instance_extension() will call strcmp() on uninitialized memory.
|
Author y-novikov not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author y-novikov not on autobuild list. Waiting for curator authorization before starting CI build. |
|
|
charles-lunarg
approved these changes
Dec 12, 2025
Collaborator
charles-lunarg
left a comment
charles-lunarg
left a comment
There was a problem hiding this comment.
Not having an easy to use "calloca" is annoying since then this could be put into the alloc call, but just fixing the uninitialized memory bug takes priority.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vkEnumerateInstanceExtensionProperties can fail to initialize ext_props in loader_add_instance_extensions(), in which case wsi_unsupported_instance_extension() will call strcmp() on uninitialized memory.