Fix duplicate layer output with the settings file #1828
Merged
+50
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there exists a layer in the settings file with the same name as a layer in the default search paths with a different library_path, the loader was mistaking it as a 'distinct' layer. Because the settings file allows specifying layers by their path & whether to enable/disable them, it is possible to exactly specify which layers will load, including duplicates.
|
CI Vulkan-Loader build queued with queue ID 598679. |
|
CI Vulkan-Loader build queued with queue ID 598696. |
|
CI Vulkan-Loader build # 3329 running. |
|
CI Vulkan-Loader build # 3329 passed. |
Contributor
|
The issue is fixed with this PR: |
christophe-lunarg
approved these changes
Dec 15, 2025
charles-lunarg
deleted the
prevent_default_layers_from_being_duplicates_of_settings_layers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there exists a layer in the settings file with the same name as a layer in the default search paths with a different library_path, the loader was mistaking it as a 'distinct' layer. Because the settings file allows specifying layers by their path & whether to enable/disable them, it is possible to exactly specify which layers will load, including duplicates.