[XML] Fix profile-specific definitions for EXT_texture_sRGB enums #673
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b28b214 (PR: #662; issue: #656; CC: @zmike, @oddhack) introduced
api="glcore"on<require>elements. This broke my code generator when I recently tried to update it to the latestgl.xml.I tried to update my processing of
gl.xml, but the problem is that usingapi="gl"andapi="glcore"the way b28b214 did is fundamentally incompatible with how extensions have been defined in the past.In other extensions,
<require api="gl">matches both the Compatibility and Core profiles.profile="compatibility"is used to further specify features that are exclusive to Compatibility.glcoreis only ever used for<extension supported="gl|glcore">, never for anything else. For example:But b28b214 takes
<require api="gl">to mean "Compatibility only" and<require api="glcore">to mean "Core only". This inconsistency makes it impossible to processgl.xmlfully automatically.This PR rewrites the definitions for EXT_texture_sRGB to use
profile="compatibility"for the luminance enums.