UT for EnqueueMapBuffer#259
Open
piotr-wozniak-mobica wants to merge 3 commits intoKhronosGroup:mainfrom
Open
Conversation
piotr-wozniak-mobica
force-pushed
the
ut_enqueueMapBuffer
branch
from
d6dd6d3 to
4603963
Compare
bashbaug
reviewed
Nov 15, 2023
tests/test_openclhpp.cpp
Outdated
| TEST_ASSERT_EQUAL(sizeof(int) * 1024, size); | ||
| TEST_ASSERT_EQUAL(0, num_events_in_wait_list); | ||
| TEST_ASSERT_EQUAL_PTR(nullptr, event_wait_list); | ||
| TEST_ASSERT_NOT_NULL(event); |
Contributor
There was a problem hiding this comment.
The event pointer is an optional output, so if the pointer is non-NULL then we should be writing a value to it (e.g. make_event(N), and checking that the expected value was written in the calling function.
See, for example:
OpenCL-CLHPP/tests/test_openclhpp.cpp
Lines 3772 to 3774 in f96b8f8
OpenCL-CLHPP/tests/test_openclhpp.cpp
Line 3791 in f96b8f8
tests/test_openclhpp.cpp
Outdated
Comment on lines
4551
to
4552
| ret = enqueueMapBuffer(bufferPool[0], blocking, flags, offset, size, events, | ||
| event, err); |
Contributor
There was a problem hiding this comment.
I don't have a very strong opinion about this, but it would require less code to pass in some of these values directly vs. assigning them to a variable first.
Suggested change
| ret = enqueueMapBuffer(bufferPool[0], blocking, flags, offset, size, events, | |
| event, err); | |
| ret = enqueueMapBuffer(bufferPool[0], CL_TRUE, CL_MAP_WRITE, 0, sizeof(int) * 1024, events, | |
| event, err); |
Contributor
|
@bashbaug Added corrections. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.