cleanup documentation and some extension handling#196
Merged
bashbaug merged 2 commits intoKhronosGroup:mainfrom Mar 17, 2023
Merged
cleanup documentation and some extension handling#196bashbaug merged 2 commits intoKhronosGroup:mainfrom
bashbaug merged 2 commits intoKhronosGroup:mainfrom
Conversation
keryell
reviewed
Mar 8, 2023
a92afcc to
afe825f
Compare
Co-authored-by: Ronan Keryell <ronan@keryell.fr>
afe825f to
faede13
Compare
keryell
approved these changes
Mar 16, 2023
Mikolaj-Filar-Mobica
approved these changes
Mar 17, 2023
Contributor
Author
|
Merging - this has two separate approvals now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a slightly reduced version of #148: it removes the extension defines for the
cl_ext_device_fissionandcl_khr_image2d_from_bufferextensions because they do not require significant code restructuring, but leaves the extension defines forcl_khr_il_programandcl_khr_subgroups.After we get in these changes we can look into improving extension handling in general with a subsequent PR.
Other related improvements:
CL_HPP_TARGET_OPENCL_VERSIONandCL_HPP_MINIMUM_OPENCL_VERSION.CL_DEVICE_PARENT_DEVICE_EXTshould return acl::Devicenot acl_device_id, similar to the query forCL_DEVICE_PARENT_DEVICE.clGetExtensionFunctionAddressForPlatformif compiling for OpenCL 1.2 or newer, then callclGetExtensionFunctionAddressif compiling for pre-OpenCL 1.2.