Add the detection of a python virtual environment when searching for unhappy installation paths under Windows #514
Conversation
…unhappy installation paths under Windows - python sys.base_prefix differs from sys.prefix in conda-based installation or pip installation within a virtual env
pyproject.toml
Outdated
| dependencies = [ | ||
| "pandas>=0.25.3", | ||
| "scikit-learn>=0.22.2", | ||
| # do not necessarily use the latest version, to avoid undesired breaking |
There was a problem hiding this comment.
Remove necessarily. Fit to one line.
.github/workflows/tests.yml
Outdated
| if ($LASTEXITCODE -ne 0) { | ||
| Write-Host "::error::Status error: improper setup, as expected: khiops-python has been cloned, not installed from a package" | ||
| } | ||
| } |
There was a problem hiding this comment.
Remove this whitespace.
| # Install the Python requirements inside a venv | ||
| # The venv python executable is used here | ||
| Get-Content .\requires.txt ` | ||
| | ForEach-Object {khiops-windows-venv\Scripts\python -m pip install $_.toString()} | ||
There was a problem hiding this comment.
Instead of a ForEach-Object loop simply use python -m pip install --requirements requires.txt
There was a problem hiding this comment.
It was a existing code, maybe it was to avoid issues manipulating multi-lines file under DOS (\r\n) ?
But OK to simplify this
There was a problem hiding this comment.
With the current command we are sure we get one dependency per line.
| # Print status | ||
| # The venv python executable is used here | ||
| Invoke-Expression -Command "Scripts\python -c 'import sys; import khiops.core as kh; return_code = kh.get_runner().print_status(); sys.exit(return_code)'" | ||
| # The installation status MUST not fail |
There was a problem hiding this comment.
Add a whiteline above to make a paragraph.
.github/workflows/tests.yml
Outdated
| # Install khiops-python in the python venv using the sources | ||
| Invoke-Expression -Command "khiops-windows-venv\Scripts\Activate.ps1" | ||
| # The venv python executable is used here | ||
| Invoke-Expression -Command "khiops-windows-venv\Scripts\python -m pip install ." |
There was a problem hiding this comment.
If you are using directly the venv python path I don't think it is necessary to activate it. So I'd remove the first command.
tramora
force-pushed
the
fix-unhappy-paths-detection-windows
branch
from
8281994 to
4dc2b18
Compare
tramora
force-pushed
the
fix-unhappy-paths-detection-windows
branch
from
4dc2b18 to
c240e99
Compare
TODO Before Asking for a Review
dev(ormainfor release PRs)Unreleasedsection ofCHANGELOG.md(no date)index.html