Add validateUserInput for client-side validation #3089
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🗄️ Schema Change: No Changes ✅ |
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (79d2b77) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3089If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3089If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3089 |
Contributor
|
Size Change: +102 B (+0.02%) Total Size: 499 kB
ℹ️ View Unchanged
|
Contributor
🛠️ Item Splitting: No Changes ✅ |
…serInput function to perseus-score
handeyeco
commented
Dec 4, 2025
| import {scorePerseusItem, scoreWidgetsFunctional} from "./score"; | ||
| import {getExpressionWidget, getTestDropdownWidget} from "./util/test-helpers"; | ||
|
|
||
| describe("flattenScores", () => { |
| * `PerseusWidgetsMap` or ` into any function that accepts a | ||
| * `ValidationDataMap` without any mutation of data. | ||
| */ | ||
| export type ValidationDataMap = { |
Contributor
Author
There was a problem hiding this comment.
I just didn't see the point of having this type and it was keeping me from reusing helpers between scoring and validation logic. Ideally in the future we could just have a AnswerfulPerseusItem and AnswerlessPerseusItem or something.
| * If a widget says that it is empty once it is graded. | ||
| * Trying to encapsulate references to the score format. | ||
| */ | ||
| export function scoreIsEmpty(score: PerseusScore): boolean { |
Contributor
Author
There was a problem hiding this comment.
Moved a bunch of these helpers into their own files.
handeyeco
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We had
scorePerseusItemwhich validates/scores with an answerful PerseusItem and we hademptyWidgetsFunctionalwhich checks for "emptiness" with an answerless PerseusItem, but we didn't have a helper that did full client-side validation which we'll need before we can removescorePerseusItem(and answerful PerseusItems) from the client.Issue: LEMS-3731