Update the omni search for romanized gurmukhi#300
Open
Gauravjeetsingh wants to merge 6 commits intoKhalisFoundation:devfrom
Open
Update the omni search for romanized gurmukhi#300Gauravjeetsingh wants to merge 6 commits intoKhalisFoundation:devfrom
Gauravjeetsingh wants to merge 6 commits intoKhalisFoundation:devfrom
Conversation
mandeeps708
requested changes
Mar 10, 2026
Comment on lines
+13
to
17
| 103: '090', // ਸ: 'ਸ਼' | ||
| 106: '122', // ਖ: 'ਖ਼' | ||
| 115: '083', // ਗ: 'ਗ਼' | ||
| '075': '094', // ਜ: 'ਜ਼' | ||
| '080': '038', // ਫ: 'ਫ਼' |
Contributor
There was a problem hiding this comment.
Should all of these keys have string data type for consistency?
| @@ -1,4 +1,4 @@ | |||
| import fetch from 'node-fetch'; | |||
| // Native fetch is available in Node 18+ | |||
Contributor
There was a problem hiding this comment.
This line can be removed. Node 18 has reached EOL one year ago.
| matchingStrategy: 'all', | ||
| }; | ||
|
|
||
| const phonticParams = { |
| }; | ||
|
|
||
| const phonticParams = { | ||
| limit: 40, |
Contributor
There was a problem hiding this comment.
Should it be 40 for prod as well?
Collaborator
Author
There was a problem hiding this comment.
Yes, it would be 40, also updated the search flow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Search the meilisearch with phonetic search, transliteration and the first letters.
And then combine all results based on their match score for the final results.
Also, update the API's compatibilty to support Node js 22