Skip to content

Conversation

@spbsoluble
Copy link
Collaborator

No description provided.

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
…ntegration-manifest.json

feat(cli/pam): Add support for get and delete pam types.
fix(cli/pam): Remove check for bug ab#63171

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
…ile for PAM types.

refactor(cli/pam): Split PAM code into 2 files one for PAM Types and the other for PAM providers.

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
…avoid storing creds on disk and in env vars.

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
… passed

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
BREAKING CHANGE: All `pam types-*` are now `pam-types <action>`

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
…e changes for a profile.

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
…some of the definition issues.

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Copilot AI review requested due to automatic review settings December 8, 2025 22:10
…in permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the application to version 1.9.0 with several significant changes including dependency upgrades, new PAM types functionality, and extensive test coverage improvements.

Key Changes:

  • Version bumped from 1.8.5 to 1.9.0 with build date of 2025-12-04
  • Major dependency updates including Azure SDK, Go client SDK, and various other packages
  • Re-enabled documentation generation via --makedocs flag
  • Introduced new pam-types command structure separating PAM provider management from PAM type management
  • Added comprehensive test coverage for store types and PAM types with mock HTTP server tests
  • Updated store_types.json with new Kemp store type and removed obsolete types

Notable Additions:

  • New embedded PAM types JSON file with 9 PAM provider types
  • Extensive new test files for store types and PAM types validation
  • Mock HTTP server test infrastructure for API testing
  • Interactive authentication fallback mechanism

Reviewed changes

Copilot reviewed 116 out of 118 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pkg/version/version.go Version bumped to 1.9.0, build date set to 2025-12-04
go.mod / go.sum Updated Go version to 1.25 and upgraded multiple dependencies
main.go Re-enabled makedocs flag functionality
store_types.json Added Kemp store type, removed entries, enabled Enrollment on several types
cmd/pam_types.json New embedded PAM types definition file with 9 provider types
cmd/pamTypes.go New 900+ line file implementing pam-types command structure
cmd/storeTypes_test.go Complete rewrite with comprehensive validation tests
cmd/pamTypes_test.go New comprehensive test file for PAM types validation
cmd/*_mock_test.go New mock HTTP server test infrastructure
cmd/root.go Added interactive auth fallback in initClient functions
docs/*.md Updated auto-generation dates and command references

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 116 out of 118 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Copilot AI review requested due to automatic review settings December 15, 2025 17:33
…ting multiple store-types and multiple errors are encountered.

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
…t --csv`

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Copilot AI review requested due to automatic review settings December 15, 2025 21:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 118 out of 120 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (3)

pkg/version/version.go:1

  • The build date is set to December 4, 2025, which is in the future relative to the current date (December 15, 2025 according to the context, but code was likely generated earlier). Build dates should typically reflect when the code was actually built, not future dates.
    cmd/storesBulkOperations.go:1
  • The nested property handling duplicates the type assertion prop.(map[string]interface{}) on line 827 after checking it on line 826. Consider storing the type assertion result in a variable to avoid duplication and improve code clarity.
    cmd/pam_types.json:1
  • Corrected spelling of 'compatability' to 'compatibility'.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…passed.

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants