84188 binding ecc renewal failure#182
Merged
indrora merged 4 commits intorelease-3.0from Mar 26, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses ECC certificate renewal issues in the IISU/WinCert PowerShell automation and expands documentation around IIS SSL Flags, while also adding generated helper scripts to create required store types via REST/curl/kfutil.
Changes:
- Update
Get-CertificateCSPto better detect ECC (ECDsa) and other CNG-backed private keys. - Add/refresh IISU SSL Flags documentation (including per-OS/IIS tables) and update related screenshots.
- Add generated scripts (PowerShell + Bash) to create the 4 store types via REST API (Invoke-RestMethod/curl) and via
kfutil.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/store_types/powershell/restmethod_create_store_types.ps1 | New generated PowerShell REST script to create store types (includes OAuth/basic auth handling). |
| scripts/store_types/powershell/kfutil_create_store_types.ps1 | New generated PowerShell script to create store types using kfutil. |
| scripts/store_types/bash/kfutil_create_store_types.sh | New generated Bash script to create store types using kfutil. |
| scripts/store_types/bash/curl_create_store_types.sh | New generated Bash script to create store types using curl (OAuth/basic auth). |
| docsource/images/WinCert-basic-store-type-dialog.png | Updated/added documentation image asset. |
| docsource/images/IISU-basic-store-type-dialog.png | Updated/added documentation image asset. |
| docsource/iisu.md | Adds required Overview section + expands SSL flags documentation. |
| README.md | Replaces placeholder with IISU SSL flags documentation content. |
| IISU/PowerShellScripts/WinCertScripts.ps1 | Version bump + ECC/CNG provider detection improvements in Get-CertificateCSP. |
| CHANGELOG.md | Adds 3.0.1 release note for ECC renewal fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+14
to
+18
| Note that SNI/SSL Flags were introduced in IIS 8.0, so they are not available in Windows Server 2012 (IIS 8.0) and earlier versions, nor supported in this extension. | ||
|
|
||
| --- | ||
|
|
||
| #### Windows Server 20162012 R2/Windows 8.1 (IIS 8.5) |
|
|
||
| --- | ||
|
|
||
| #### Windows Server 20162012 R2/Windows 8.1 (IIS 8.5) |
Comment on lines
+379
to
+383
| Note that SNI/SSL Flags were introduced in IIS 8.0, so they are not available in Windows Server 2012 (IIS 8.0) and earlier versions, nor supported in this extension. | ||
|
|
||
| --- | ||
|
|
||
| ##### Windows Server 20162012 R2/Windows 8.1 (IIS 8.5) |
| client_id = $env:KEYFACTOR_AUTH_CLIENT_ID | ||
| client_secret = $env:KEYFACTOR_AUTH_CLIENT_SECRET | ||
| } | ||
| $tokenResp = Invoke-RestMethod -Method Post -Uri $env:KEYFACTOR_AUTH_TOKEN_URL -Body $tokenBody |
| "DependsOn": "", | ||
| "DefaultValue": "0", | ||
| "Options": "", | ||
| "Description": "A 128-Bit Flag that determines what type of SSL settings you wish to use. The default is 0, meaning No SNI. For more information, check IIS documentation for the appropriate bit setting.)" |
Comment on lines
+29
to
+35
| echo "Fetching OAuth token..." | ||
| BEARER_TOKEN=$(curl -s -X POST "${KEYFACTOR_AUTH_TOKEN_URL}" \ | ||
| -H "Content-Type: application/x-www-form-urlencoded" \ | ||
| --data-urlencode "grant_type=client_credentials" \ | ||
| --data-urlencode "client_id=${KEYFACTOR_AUTH_CLIENT_ID}" \ | ||
| --data-urlencode "client_secret=${KEYFACTOR_AUTH_CLIENT_SECRET}" | jq -r '.access_token') | ||
| if [ -z "${BEARER_TOKEN}" ] || [ "${BEARER_TOKEN}" = "null" ]; then |
| "DependsOn": "", | ||
| "DefaultValue": "0", | ||
| "Options": "", | ||
| "Description": "A 128-Bit Flag that determines what type of SSL settings you wish to use. The default is 0, meaning No SNI. For more information, check IIS documentation for the appropriate bit setting.)" |
| @@ -1,3 +1,6 @@ | |||
| 3.0.1 | |||
| * Fixed an issues when renewing ECC Certificates | |||
Comment on lines
+1792
to
1794
| # ── 1. Legacy CryptoAPI path (RSACryptoServiceProvider) ────────────── | ||
| $privateKey = $cert.PrivateKey | ||
|
|
||
| if ($privateKey -and $privateKey.CspKeyContainerInfo) { |
Comment on lines
+1844
to
1846
| Write-Verbose "No supported key type detected; provider name could not be determined" | ||
| return "" | ||
| } |
indrora
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a problem when renewing ECC Certificates.
Updated documentation to identify SSL flags.