Fixed an issues when renewing ECC Certificates#180
Closed
rcpokorny wants to merge 2 commits intorelease-3.0from
Closed
Fixed an issues when renewing ECC Certificates#180rcpokorny wants to merge 2 commits intorelease-3.0from
rcpokorny wants to merge 2 commits intorelease-3.0from
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to resolve issues encountered when renewing ECC (ECDSA) certificates by improving cryptographic provider detection in the IISU PowerShell scripts, and updates IISU documentation/changelog to reflect SSL flag/version guidance.
Changes:
- Enhanced
Get-CertificateCSPto detect ECC (ECDsa) keys and consolidate CNG provider lookup. - Updated IISU documentation to include an Overview section and expand SSL flags information.
- Added a 3.0.1 entry to the changelog for the ECC renewal fix.
Reviewed changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| docsource/iisu.md | Adds an Overview header and expands SSL flags documentation (noted inconsistencies to address). |
| IISU/PowerShellScripts/WinCertScripts.ps1 | Updates Get-CertificateCSP for ECC/CNG provider detection and bumps script header version. |
| CHANGELOG.md | Adds release note entry for 3.0.1 (minor grammar issue noted). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,3 +1,6 @@ | |||
| 3.0.1 | |||
| * Fixed an issues when renewing ECC Certificates | |||
| @@ -1,3 +1,5 @@ | |||
| ## Overview | |||
|
|
|||
Comment on lines
+14
to
+18
| Note that SNI/SSL Flags were introduced in IIS 8.0, so they are not available in Windows Server 2012 (IIS 8.0) and earlier versions, nor supported in this extension. | ||
|
|
||
| --- | ||
|
|
||
| #### Windows Server 20162012 R2/Windows 8.1 (IIS 8.5) |
Comment on lines
+18
to
+25
| #### Windows Server 20162012 R2/Windows 8.1 (IIS 8.5) | ||
|
|
||
| | Value | Description | | ||
| |-----:|-------------| | ||
| | 0 | No SNI (traditional IP:Port binding) | | ||
| | 1 | Enable Server Name Indication (SNI) | | ||
| | 2 | Centralized Certificate Store (CCS) (Not Supported) | | ||
| | 4 | Disable HTTP/2 | |
| @@ -1,4 +1,4 @@ | |||
| # Version 1.5.0 | |||
| # Version 1.5.1 | |||
Collaborator
Author
|
created wrong merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an issues when renewing ECC Certificates and updated ReadMe identifying SSL flags were added to IIS beginning in IIS 8.0.