Fix: screenshot crush when using non-ascii file path#1697
Merged
crudelios merged 1 commit intoKeriew:masterfrom Mar 5, 2026
Merged
Fix: screenshot crush when using non-ascii file path#1697crudelios merged 1 commit intoKeriew:masterfrom
crudelios merged 1 commit intoKeriew:masterfrom
Conversation
xxoommd
force-pushed
the
fix_screenshot_crush
branch
from
7c8c138 to
d6adc77
Compare
crudelios
reviewed
Mar 3, 2026
| string_copy(prefix, notice_text, FILE_NAME_MAX); | ||
| int prefix_length = string_length(prefix); | ||
| string_copy(string_from_ascii(filename), ¬ice_text[prefix_length], FILE_NAME_MAX - prefix_length); | ||
| const uint8_t *ascii_filename = string_from_ascii(filename); |
Collaborator
There was a problem hiding this comment.
Maybe use encoding_from_utf8 instead? That would possibly display the path even if there were non-ascii characters.
Author
There was a problem hiding this comment.
Maybe use
encoding_from_utf8instead? That would possibly display the path even if there were non-ascii characters.
Thank you for you advice. I force pushed this branch again.
xxoommd
force-pushed
the
fix_screenshot_crush
branch
from
d6adc77 to
f5807bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When saving screenshot will cause the game to crash. The cause of the problem is the file path contains non-ASCII characters. Just make a NULL judgment before the pop-up window will avoid this crush.