Skip to content

🧹 Refactor ToolRegistry to dynamically identify final answer tools#268

Open
KeithCu wants to merge 1 commit intomasterfrom
fix/tool-registry-hardcoded-strings-9247852521992975344
Open

🧹 Refactor ToolRegistry to dynamically identify final answer tools#268
KeithCu wants to merge 1 commit intomasterfrom
fix/tool-registry-hardcoded-strings-9247852521992975344

Conversation

@KeithCu
Copy link
Copy Markdown
Owner

@KeithCu KeithCu commented Mar 31, 2026

🎯 What: The code health issue addressed
Removed the hardcoded list of strings (["final_answer", "specialized_workflow_finished", "reply_to_user"]) in plugin/framework/tool_registry.py and replaced it with a dynamic boolean check getattr(t, "is_final_answer_tool", False). Added is_final_answer_tool = False to ToolBase and overrode it as True in the SpecializedWorkflowFinished tool.

💡 Why: How this improves maintainability
This prevents the ToolRegistry from needing to know the specific names of final answer tools across different domains. Hardcoding class names/identifiers in a central registry makes adding new tools brittle and couples the registry to specific features (e.g. Writer specialized tools, Librarian). By using a boolean flag, tools can self-declare their role in the workflow.

Verification: How you confirmed the change is safe
Ran uv run ty check plugin/framework/tool_registry.py to verify type safety. Ran the full pytest suite (uv run pytest plugin/tests/) and confirmed all tests pass without introducing new failures. Validated that reply_to_user and final_answer are handled dynamically as final_answer_tool_name parameters within smolagents and thus never needed to be in the ToolBase list anyway.

Result: The improvement achieved
A cleaner, decoupled ToolRegistry that scales safely with new tools and cleanly relies on properties of the ToolBase hierarchy.


PR created automatically by Jules for task 9247852521992975344 started by @KeithCu

Co-authored-by: KeithCu <662157+KeithCu@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant