Closed
Conversation
Owner
|
While the contribution is apprciates I've already fixed this in the dev branch just haven't gotten around to merging and building it yet. Just did that so 2.4.1 should be up now. If you want you can fix the conflicts and I'll merge it for the other bits I didn't implement in my fix (like always flushing the buffer or explicitly joining). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! Been trying to use the injector for some benchmarks of Factorio. Ran into an issue which was reported in #13 and I believe I have found a fix for this.
The injector should now exit whenever the child process (Factorio, Stellaris, etc.) exits.