chore: golangci-lint 부채 해소 + chart icon branding 정정#305
Merged
Conversation
main CI 의 기존(pre-existing) lint/test red 를 정리 (코드품질·일관성). - cluster_reintegrate.go: rangeint ×4 (for i:=0;i<N;i++ → for i:=range N). - valkeyrestore_controller_test.go: newexpr (ptr.To → new) + 미사용 ptr import 제거. - servicemonitor_test.go: goimports import 그룹 재정렬 (stdlib/external/local). - statefulset.go: clusterAnnounceCommand unparam — 항상 nil 인 2nd return 제거, 호출 측 Args=nil 명시 (거동 동일). - Chart.yaml: icon → https://valkey.io/img/valkey-horizontal.svg (TestChartIconURLUsesCurrentValkeyAsset 통과 — 과거 404 자산 정정). 검증: gofmt 0 / golangci-lint 0 issues / go build OK / branding+resources test ok / KUBEBUILDER_ASSETS=… controller envtest 전체 suite ok (17.1s). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: phil <phil@keiailab.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요약
main CI 의 기존(pre-existing) lint/test red 정리 — 직전 commons 채택 PR(#304)과 무관한 repo 부채.
cluster_reintegrate.gorangeint ×4for i:=0;i<N;i++→for i:=range Nvalkeyrestore_controller_test.gonewexprptr.To→new+ 미사용 import 제거servicemonitor_test.gogoimportsstatefulset.gounparamclusterAnnounceCommand항상-nil 2nd return 제거 (거동 동일)Chart.yamlbrandingvalkey.io/img/valkey-horizontal.svg(TestChartIconURL…통과)검증
🤖 Generated with Claude Code