chore: golangci-lint goconst 해소 + dead code 제거#382
Merged
Conversation
- builder.go: "metrics" 포트명 리터럴 4회 → metricsPortName 상수 (goconst SSOT). - buildDataVolumeClaimTemplate 제거 (dead code, 호출처 0, lint:ignore U1000). commons pkg/pvc.BuildDataPVC 가 적법한 대체 home. 제거로 잘못 삽입됐던 tlsArgs doc 주석이 func tlsArgs 와 재결합 (오삽입 정정). 검증: gofmt 0 / go build ./... OK / go vet clean / golangci-lint 0 issues / go test resources ok. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: phil <phil@keiailab.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요약
main golangci-lint 부채 해소 + dead code 정리.
builder.go: "metrics" 포트명 리터럴 4회 →metricsPortName상수 (goconst, 카운트 불변·동작 동일).buildDataVolumeClaimTemplate제거 — dead code(호출처 0,lint:ignore U1000). commonspkg/pvc.BuildDataPVC(v0.13.0)가 적법한 대체. 제거로 잘못 삽입됐던tlsArgsdoc 주석이 함수와 재결합.검증
🤖 Generated with Claude Code