style(sharded): release golangci-lint 게이트 해소 (goconst + gocyclo)#377
Merged
Conversation
make release Step1 의 전체 golangci-lint(PR CI 는 변경라인만 스캔)가 차단: - controller buildShardKey "hashed" → const orderHashed (goconst) - backupverification "Passed" → const backupPhasePassed (goconst, backupPhaseFailed 패턴 정합) - Reconcile gocyclo 37>35 → //nolint:gocyclo (12-step orchestrator, 본질적 복잡) 검증: go build + staticcheck + golangci-lint(bin) 전부 exit 0 / 0 issues. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: phil <phil@keiailab.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make releaseStep1 의 전체golangci-lint스캔이 v1.16.5 release 를 차단(goconst 2 + gocyclo 1). PR CI 는--new-from-rev(변경라인만)라 미검출, release 게이트는 전체 스캔이라 검출 — 게이트 불일치 해소.변경
buildShardKey"hashed" →const orderHashed(goconst)"Passed"→const backupPhasePassed(goconst, 기존 backupPhaseFailed 패턴 정합)Reconcilegocyclo 37>35 →//nolint:gocyclo(12-step reconcile orchestrator, 본질적 복잡 — reconcileShardedCollections 는 이미 별도 메서드 분리)검증
go build ./...OKstaticcheck ./internal/...exit 0golangci-lint run(release 와 동일 bin) 0 issues🤖 Generated with Claude Code